Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MAINT) Bug Fix - ship sar metrics #214

Merged
merged 1 commit into from
Mar 26, 2024
Merged

(MAINT) Bug Fix - ship sar metrics #214

merged 1 commit into from
Mar 26, 2024

Conversation

coreymbe
Copy link
Contributor

Summary

This commit fixes a bug that was preventing system_cpu metrics collected via puppet_metrics_collector::system from being shipped to Splunk.

Detailed Description

  • lib/puppet/application/splunk_hec.rb
    • Added logic to allow for Array of sar metrics to be shipped to Splunk.
      • Previously the code assumed that the metrics would be in Hash format.
  • Updated CHANGELOG.md

Checklist

[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

@coreymbe coreymbe requested a review from a team as a code owner March 26, 2024 19:29
actowery
actowery approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@actowery actowery merged commit f0c4fee into puppetlabs:main Mar 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@actowery actowery actowery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreymbe @actowery